Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Fix for build break Defect 303094 #30570

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Issue Fix for build break Defect 303094 #30570

merged 1 commit into from
Jan 31, 2025
+2 −2

Conversation

pardhivkrishna
Copy link
Contributor

Increasing the transaction timeout

@pardhivkrishna pardhivkrishna self-assigned this Jan 16, 2025
@pardhivkrishna
Copy link
Contributor Author

pardhivkrishna commented Jan 16, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 1 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@tkburroughs
Copy link
Member

I'm not very familiar with this component or FAT, so I've added @njr-11 and @KyleAure to provide a better opinion as to whether my recommendation for adjusting the missedTaskThreshold will have any negative impact to this test.

njr-11
njr-11 requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the transaction timeout

The changes within this PR do not increase the transaction timeout, nor do they increase the missedTaskThreshold as Tracy points out.

The team owning this bucket needs to spend time to understand what the test is doing, perform investigation of the failure, and write up a description of the problem in the issue or PR as they understand and how they are expecting to solve it. It is not the place of the code reviewer to do that work instead. That would be backwards. The only work I see here documenting any investigation or analysis is all from Brian before transferring this defect over, and from Tracy in attempting to review it.

You can use the information they have kindly provided, but you need to perform your own analysis taking that into account and be able to explain and justify whatever change you are making.

@pardhivkrishna
Copy link
Contributor Author

pardhivkrishna commented Jan 29, 2025 •
edited by LibbyBot
Loading

#build
(view Open Liberty Personal Build - ✅ completed successfully!)
#spawn.fullfat.buckets=com.ibm.ws.concurrent.persistent_fat_locking

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 1 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_cBq0sN6QEe-M5OZShUU9WA

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@pardhivkrishna pardhivkrishna merged commit 2525df8 into OpenLiberty:integration Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAure KyleAure KyleAure approved these changes

@tkburroughs tkburroughs tkburroughs approved these changes

@njr-11 njr-11 njr-11 approved these changes

Assignees

@pardhivkrishna pardhivkrishna

Labels
in:JPA noproductcode
Projects
None yet
Milestone
[Iteration 25.1] Jan 6 - Jan 17
Development

Successfully merging this pull request may close these issues.
5 participants
@pardhivkrishna @LibbyBot @tkburroughs @njr-11 @KyleAure